Messages in this thread | | | Date | Fri, 14 Jul 2023 11:01:16 +0000 | From | Simon Ser <> | Subject | Re: [PATCH 5/8] drm/client: Convert drm_mode_create_dumb() to drm_mode_addfb2() |
| |
On Thursday, July 13th, 2023 at 15:17, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Currently drm_client_buffer_addfb() uses the legacy drm_mode_addfb(), > which uses bpp and depth to guess the wanted buffer format. > However, drm_client_buffer_addfb() already knows the exact buffer > format, so there is no need to convert back and forth between buffer > format and bpp/depth, and the function can just call drm_mode_addfb2() > directly instead.
By any chance, is the commit message wrong? The title refers to drm_mode_create_dumb(), but the description and code refer to drm_client_buffer_addfb().
| |