Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 14 Jul 2023 13:29:18 +0200 | Subject | Re: [PATCH 5/8] drm/client: Convert drm_mode_create_dumb() to drm_mode_addfb2() |
| |
Hi Simon,
On Fri, Jul 14, 2023 at 1:01 PM Simon Ser <contact@emersion.fr> wrote: > On Thursday, July 13th, 2023 at 15:17, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Currently drm_client_buffer_addfb() uses the legacy drm_mode_addfb(), > > which uses bpp and depth to guess the wanted buffer format. > > However, drm_client_buffer_addfb() already knows the exact buffer > > format, so there is no need to convert back and forth between buffer > > format and bpp/depth, and the function can just call drm_mode_addfb2() > > directly instead. > > By any chance, is the commit message wrong? The title refers to > drm_mode_create_dumb(), but the description and code refer to > drm_client_buffer_addfb().
Yes it is, thanks. Originally, I had copied-and-pasted the wrong function name. I thought I had fixed all references, but apparently I missed the one-line summary :-(
Will fix in v2.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |