Messages in this thread | | | Date | Wed, 3 May 2023 17:08:37 +0200 | Subject | Re: [PATCH 2/3] thermal/drivers/mediatek/lvts_thermal: Honor sensors in immediate mode | From | AngeloGioacchino Del Regno <> |
| |
Il 28/04/23 21:53, Nícolas F. R. A. Prado ha scritto: > Each controller can be configured to operate on immediate or filtered > mode. On filtered mode, the sensors are enabled by setting the > corresponding bits in MONCTL0, while on immediate mode, by setting > MSRCTL1. > > Previously, the code would set MSRCTL1 for all four sensors when > configured to immediate mode, but given that the controller might not > have all four sensors connected, this would cause interrupts to trigger > for non-existent sensors. Fix this by handling the MSRCTL1 register > analogously to the MONCTL0: only enable the sensors that were declared. > > Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Awesome!!!!!
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
| |