Messages in this thread | | | Date | Tue, 2 May 2023 12:00:10 +0200 | Subject | Re: [PATCH 1/3] thermal/drivers/mediatek/lvts_thermal: Handle IRQ on all controllers | From | Matthias Brugger <> |
| |
On 28/04/2023 21:53, Nícolas F. R. A. Prado wrote: > There is a single IRQ handler for each LVTS thermal domain, and it is > supposed to check each of its underlying controllers for the origin of > the interrupt and clear its status. However due to a typo, only the > first controller was ever being handled, which resulted in the interrupt > never being cleared when it happened on the other controllers. Add the > missing index so interrupts are handled for all controllers. > > Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> >
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> --- > > drivers/thermal/mediatek/lvts_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c > index d0a3f95b7884..56b24c5b645f 100644 > --- a/drivers/thermal/mediatek/lvts_thermal.c > +++ b/drivers/thermal/mediatek/lvts_thermal.c > @@ -449,7 +449,7 @@ static irqreturn_t lvts_irq_handler(int irq, void *data) > > for (i = 0; i < lvts_td->num_lvts_ctrl; i++) { > > - aux = lvts_ctrl_irq_handler(lvts_td->lvts_ctrl); > + aux = lvts_ctrl_irq_handler(&lvts_td->lvts_ctrl[i]); > if (aux != IRQ_HANDLED) > continue; >
| |