Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 24 Apr 2023 21:37:00 +0200 | Subject | Re: [PATCH 05/11] media: renesas: fdp1: remove R-Car H3 ES1.* handling |
| |
Hi Wolfram,
On Mon, Apr 24, 2023 at 9:17 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > > -#define FD1_IP_H3_ES1 0x02010101 > > ... > > > Apparently 0x02010101 is also used on (at least) R-Car M2-W ES1.0, > > causing the following annoying (but further harmless?) messages > > during boot: > > > > rcar_fdp1 fe940000.fdp1: FDP1 Unidentifiable (0x02010101) > > rcar_fdp1 fe944000.fdp1: FDP1 Unidentifiable (0x02010101) > > Hmm, that means before my removal patch, Gen2 has been incorrectly > defined as H3 ES1?
Indeed, but the driver doesn't seem to do anything with the detected version, except for printing a debug or error message.
> > Note that the R-Car Gen2 documentation states the register's contents > > are all zeroes. But that value would trigger the error message, too. > > Bad, but well... > > > Sorry for not noticing before. Apparently I never booted a kernel > > with this patch on koelsch... > > We could re-add this version and just let it print "FDP1 Initial > Version" or something? I could test this on my Lager board.
I plan to test it on a few other boards, too... Just wanted to let you know ASAP...
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |