Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 24 Apr 2023 19:37:53 +0200 | Subject | Re: [PATCH 05/11] media: renesas: fdp1: remove R-Car H3 ES1.* handling |
| |
Hi Wolfram,
On Tue, Mar 7, 2023 at 5:31 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > R-Car H3 ES1.* was only available to an internal development group and > needed a lot of quirks and workarounds. These become a maintenance > burden now, so our development group decided to remove upstream support > and disable booting for this SoC. Public users only have ES2 onwards. > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks for your patch, which is now commit af4273b43f2bd9ee ("media: renesas: fdp1: remove R-Car H3 ES1.* handling") in media/master (next-20230417 and later).
> --- a/drivers/media/platform/renesas/rcar_fdp1.c > +++ b/drivers/media/platform/renesas/rcar_fdp1.c > @@ -254,7 +254,6 @@ MODULE_PARM_DESC(debug, "activate debug info"); > > /* Internal Data (HW Version) */ > #define FD1_IP_INTDATA 0x0800 > -#define FD1_IP_H3_ES1 0x02010101 > #define FD1_IP_M3W 0x02010202 > #define FD1_IP_H3 0x02010203 > #define FD1_IP_M3N 0x02010204 > @@ -2359,9 +2358,6 @@ static int fdp1_probe(struct platform_device *pdev) > > hw_version = fdp1_read(fdp1, FD1_IP_INTDATA); > switch (hw_version) { > - case FD1_IP_H3_ES1: > - dprintk(fdp1, "FDP1 Version R-Car H3 ES1\n"); > - break; > case FD1_IP_M3W: > dprintk(fdp1, "FDP1 Version R-Car M3-W\n"); > break;
Apparently 0x02010101 is also used on (at least) R-Car M2-W ES1.0, causing the following annoying (but further harmless?) messages during boot:
rcar_fdp1 fe940000.fdp1: FDP1 Unidentifiable (0x02010101) rcar_fdp1 fe944000.fdp1: FDP1 Unidentifiable (0x02010101)
Note that the R-Car Gen2 documentation states the register's contents are all zeroes. But that value would trigger the error message, too.
Sorry for not noticing before. Apparently I never booted a kernel with this patch on koelsch...
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |