Messages in this thread | | | Date | Mon, 24 Apr 2023 21:17:30 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH 05/11] media: renesas: fdp1: remove R-Car H3 ES1.* handling |
| |
Hi Geert,
thanks for reporting!
> > -#define FD1_IP_H3_ES1 0x02010101
...
> Apparently 0x02010101 is also used on (at least) R-Car M2-W ES1.0, > causing the following annoying (but further harmless?) messages > during boot: > > rcar_fdp1 fe940000.fdp1: FDP1 Unidentifiable (0x02010101) > rcar_fdp1 fe944000.fdp1: FDP1 Unidentifiable (0x02010101)
Hmm, that means before my removal patch, Gen2 has been incorrectly defined as H3 ES1?
> Note that the R-Car Gen2 documentation states the register's contents > are all zeroes. But that value would trigger the error message, too.
Bad, but well...
> Sorry for not noticing before. Apparently I never booted a kernel > with this patch on koelsch...
We could re-add this version and just let it print "FDP1 Initial Version" or something? I could test this on my Lager board.
All the best,
Wolfram
[unhandled content-type:application/pgp-signature] | |