Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH 11/17] iommu/vt-d: Fix operand size in bitwise operation | Date | Wed, 12 Apr 2023 07:11:24 +0000 |
| |
From: Baolu Lu > Sent: 12 April 2023 02:32 > > On 4/12/23 5:22 AM, David Laight wrote: > >> Sent: 11 April 2023 07:48 > >> > >> From: Tina Zhang<tina.zhang@intel.com> > >> > >> The patch fixes the klocwork issues that operands in a bitwise operation > >> have different size at line 1692 of dmar.c, line 1898 and line 1907 of > >> iommu.c. > > Why is this any kind of thing that needs fixing? > > This description is a bit misleading. Actually I queued it as a cleanup > patch.
Hopefully without 'fix' anywhere in the description. Otherwise the scripts will pick it for a back-port.
> > - val |= (1 << 11) | 1; > > + val |= BIT_ULL(11) | BIT_ULL(0);
More problematic it what is bit 11 anyway?
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |