Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH 11/17] iommu/vt-d: Fix operand size in bitwise operation | Date | Tue, 11 Apr 2023 21:22:52 +0000 |
| |
From: Lu Baolu > Sent: 11 April 2023 07:48 > > From: Tina Zhang <tina.zhang@intel.com> > > The patch fixes the klocwork issues that operands in a bitwise operation > have different size at line 1692 of dmar.c, line 1898 and line 1907 of > iommu.c.
Why is this any kind of thing that needs fixing?
David
> Reported-by: Yongwei Ma <yongwei.ma@intel.com> > Signed-off-by: Tina Zhang <tina.zhang@intel.com> > Link: https://lore.kernel.org/r/20230406065944.2773296-2-tina.zhang@intel.com > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> > --- > drivers/iommu/intel/dmar.c | 2 +- > drivers/iommu/intel/iommu.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c > index 23828d189c2a..f0f51c957ccb 100644 > --- a/drivers/iommu/intel/dmar.c > +++ b/drivers/iommu/intel/dmar.c > @@ -1690,7 +1690,7 @@ static void __dmar_enable_qi(struct intel_iommu *iommu) > * is present. > */ > if (ecap_smts(iommu->ecap)) > - val |= (1 << 11) | 1; > + val |= BIT_ULL(11) | BIT_ULL(0); > > raw_spin_lock_irqsave(&iommu->register_lock, flags); > > diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c > index f4e536fd5a28..acbf82fa90e7 100644 > --- a/drivers/iommu/intel/iommu.c > +++ b/drivers/iommu/intel/iommu.c > @@ -1870,7 +1870,7 @@ context_set_sm_rid2pasid(struct context_entry *context, unsigned long pasid) > */ > static inline void context_set_sm_dte(struct context_entry *context) > { > - context->lo |= (1 << 2); > + context->lo |= BIT_ULL(2); > } > > /* > @@ -1879,7 +1879,7 @@ static inline void context_set_sm_dte(struct context_entry *context) > */ > static inline void context_set_sm_pre(struct context_entry *context) > { > - context->lo |= (1 << 4); > + context->lo |= BIT_ULL(4); > } > > /* Convert value to context PASID directory size field coding. */ > -- > 2.34.1
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |