Messages in this thread Patch in this message | | | Date | Sat, 1 Apr 2023 11:56:43 +0300 | From | Arınç ÜNAL <> | Subject | Re: [PATCH net-next 13/15] net: dsa: mt7530: add support for 10G link modes for CPU port |
| |
On 30.03.2023 18:23, Daniel Golle wrote: > The built-in switch of the MT7988 SoC is internally connected using > a stateless 10G link. Add support for 10G interface modes to silence > a warning otherwise occurring when the switch driver is setup. > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Daniel Golle <daniel@makrotopia.org> > --- > drivers/net/dsa/mt7530.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index 3a4682e71e746..ac666da2d10dc 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -2618,6 +2618,9 @@ mt7531_mac_config(struct dsa_switch *ds, int port, unsigned int mode, > case PHY_INTERFACE_MODE_1000BASEX: > case PHY_INTERFACE_MODE_2500BASEX: > /* handled in SGMII PCS driver */ > + case PHY_INTERFACE_MODE_USXGMII: > + case PHY_INTERFACE_MODE_10GKR: > + /* internal stateless 10G link */ > return 0; > default: > return -EINVAL;
I think it'd be better to make this explicitly for the switch in the MT7988 SoC.
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index e5347dd2521b..f7542c7f60e4 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2666,10 +2665,13 @@ mt7531_mac_config(struct dsa_switch *ds, int port, unsigned int mode, case PHY_INTERFACE_MODE_1000BASEX: case PHY_INTERFACE_MODE_2500BASEX: /* handled in SGMII PCS driver */ + return 0; case PHY_INTERFACE_MODE_USXGMII: case PHY_INTERFACE_MODE_10GKR: - /* internal stateless 10G link */ - return 0; + if (priv->id == ID_MT7988) + /* internal stateless 10G link */ + return 0; + default: return -EINVAL; } Arınç
| |