Messages in this thread | | | From | Javier Martinez Canillas <> | Subject | Re: [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support | Date | Mon, 27 Mar 2023 10:16:08 +0200 |
| |
Jarrah <kernel@undef.tools> writes:
> Hi Javier, > > On 3/27/23 18:41, Javier Martinez Canillas wrote: >> From: Ondrej Jirman <megi@xff.cz> >> >> The phone's display is using a Hannstar LCD panel. Support it by adding a >> panel DT node and all needed nodes (backlight, MIPI DSI, regulators, etc). >> >> Signed-off-by: Ondrej Jirman <megi@xff.cz> >> Co-developed-by: Martijn Braam <martijn@brixit.nl> >> Co-developed-by: Kamil Trzciński <ayufan@ayufan.eu> >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> >> --- >> >> Changes in v2: >> - Drop touchscreen node because used the wrong compatible (Ondrej Jirman). > > > Any reason not to include this with the correct compatible string? It's > been available since > https://lore.kernel.org/all/20220813043821.9981-1-kernel@undef.tools/. > Swapping out gt917s for gt1158 in the node from your previous patch > should be enough. >
Yes, but I didn't know that the driver already had the compatible string so I just dropped it for now and was meaning to take a look to that later.
Adding the touchscreen node can be done as a follow-up though in another patch.
-- Best regards,
Javier Martinez Canillas Core Platforms Red Hat
| |