Messages in this thread | | | From | Heiko Stübner <> | Subject | Re: [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support | Date | Mon, 27 Mar 2023 17:57:39 +0200 |
| |
Am Montag, 27. März 2023, 17:39:57 CEST schrieb Javier Martinez Canillas: > Ondřej Jirman <megi@xff.cz> writes: > > Hell Ondřej, > > > Hi Javier, > > > > I've tried the patch on top of linus/master and it works as expected. My > > DRM test app shows 16.669ms between frames. The display output is ok on > > developer batch pinephone pro, and is corrupted on production version. > > Display also doesn't come back after blanking. All as expected. > > > > Tested-by: Ondrej Jirman <megi@xff.cz> > > > > Thanks for testing. > > > A few more comments below. > > > > I'm OK with these comments but I did a git diff with your orange-pi-6.3 > branch just before posting and this was the latest that's in your tree. > > So feel free to either post a v3 addressing the things you are pointing > out or lets land this and we can post any further cleanups on top IMO.
I would really like to _not_ apply essentially broken code, so really would prefer the v3-approach.
Thanks Heiko
| |