Messages in this thread | | | Date | Mon, 27 Mar 2023 21:56:11 +0300 | From | Vladimir Oltean <> | Subject | Re: [PATCH net 3/7] net: dsa: mt7530: do not run mt7530_setup_port5() if port 5 is disabled |
| |
On Sun, Mar 26, 2023 at 05:08:14PM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > There's no need to run all the code on mt7530_setup_port5() if port 5 is > disabled. Run mt7530_setup_port5() if priv->p5_intf_sel is not P5_DISABLED > and remove the P5_DISABLED case from mt7530_setup_port5(). > > Stop initialising the interface variable as the remaining cases will always > call mt7530_setup_port5() with it initialised. > > Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5") > Tested-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > ---
Again, not sure what is the problem, and how this solution addresses that problem. I see Fixes tags for all patches, but I don't understand what they fix, what didn't work before that works now?
| |