Messages in this thread | | | Date | Thu, 2 Mar 2023 15:11:21 +0530 | Subject | Re: [PATCH 1/2] dt-bindings: mfd: Add MAX5970 and MAX5978 | From | Naresh Solanki <> |
| |
Hi Krzytof,
On 02-03-2023 01:56 pm, Krzysztof Kozlowski wrote: > On 01/03/2023 10:12, Naresh Solanki wrote: >> From: Marcello Sylvester Bauer <sylv@sylv.io> >> >> The MAX597x is a hot swap controller with configurable fault protection. >> It also has 10bit ADC for current & voltage measurements. >> >> Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io> >> Co-developed-by: Patrick Rudolph <patrick.rudolph@9elements.com> >> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> >> Co-developed-by: Naresh Solanki <Naresh.Solanki@9elements.com> >> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> > > It's v12 or what? Where are previous tags? Or you ignored entire review > and sent something new? > > You already got the comments about it, so basically you ignore it second > time... > > Where is the changelog? My bad I missed updating the same. Will include it. > >> --- >> .../bindings/mfd/maxim,max5970.yaml | 151 ++++++++++++++++++ >> 1 file changed, 151 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max5970.yaml >> >> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max5970.yaml b/Documentation/devicetree/bindings/mfd/maxim,max5970.yaml >> new file mode 100644 >> index 000000000000..6ee269afdab2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/maxim,max5970.yaml >> @@ -0,0 +1,151 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/mfd/maxim,max5970.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Regulator for MAX5970 smart switch from Maxim Integrated. > > Drop the full stop. It's title, so follows the title grammar rules (you > could also capitalize it but it's matter of style > https://www.grammarly.com/blog/capitalization-in-the-titles/). Sure. > > I don't know whether I should review rest or not... just in case I don't > want to waste my time, so I'll skip it. > > > Best regards, > Krzysztof >
| |