Messages in this thread | | | Date | Thu, 2 Mar 2023 12:11:08 +0800 | From | kernel test robot <> | Subject | Re: [PATCH 2/2] mfd: max597x: Add support for MAX5970 and MAX5978 |
| |
Hi Naresh,
I love your patch! Perhaps something to improve:
[auto build test WARNING on 59c54c59974649b2e7bc92faae4a21e2b2408db2]
url: https://github.com/intel-lab-lkp/linux/commits/Naresh-Solanki/mfd-max597x-Add-support-for-MAX5970-and-MAX5978/20230301-171527 base: 59c54c59974649b2e7bc92faae4a21e2b2408db2 patch link: https://lore.kernel.org/r/20230301091234.3159953-2-Naresh.Solanki%409elements.com patch subject: [PATCH 2/2] mfd: max597x: Add support for MAX5970 and MAX5978 config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230302/202303021248.Bk9jYUb1-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/68623f7868d887a57422ce2cd6f5dc1ee1510f1e git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Naresh-Solanki/mfd-max597x-Add-support-for-MAX5970-and-MAX5978/20230301-171527 git checkout 68623f7868d887a57422ce2cd6f5dc1ee1510f1e # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/regulator/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202303021248.Bk9jYUb1-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/regulator/max597x-regulator.c: In function 'max597x_regulator_probe': drivers/regulator/max597x-regulator.c:447:41: error: 'struct max597x_data' has no member named 'dev' 447 | devm_kzalloc(max597x->dev, sizeof(struct max597x_regulator), | ^~ drivers/regulator/max597x-regulator.c:453:39: error: 'struct max597x_data' has no member named 'regmap' 453 | data->regmap = max597x->regmap; | ^~ drivers/regulator/max597x-regulator.c:462:37: error: 'struct max597x_data' has no member named 'dev' 462 | config.dev = max597x->dev; | ^~ drivers/regulator/max597x-regulator.c:465:55: error: 'struct max597x_data' has no member named 'dev' 465 | rdev = devm_regulator_register(max597x->dev, | ^~ In file included from include/linux/device.h:15, from drivers/regulator/max597x-regulator.c:11: drivers/regulator/max597x-regulator.c:468:40: error: 'struct max597x_data' has no member named 'dev' 468 | dev_err(max597x->dev, "failed to register regulator %s\n", | ^~ include/linux/dev_printk.h:110:25: note: in definition of macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~ drivers/regulator/max597x-regulator.c:468:25: note: in expansion of macro 'dev_err' 468 | dev_err(max597x->dev, "failed to register regulator %s\n", | ^~~~~~~ drivers/regulator/max597x-regulator.c:476:20: error: 'struct max597x_data' has no member named 'irq' 476 | if (max597x->irq) { | ^~ drivers/regulator/max597x-regulator.c:478:46: error: 'struct max597x_data' has no member named 'dev' 478 | max597x_setup_irq(max597x->dev, max597x->irq, rdevs, num_switches, | ^~ drivers/regulator/max597x-regulator.c:478:60: error: 'struct max597x_data' has no member named 'irq' 478 | max597x_setup_irq(max597x->dev, max597x->irq, rdevs, num_switches, | ^~ In file included from include/linux/device.h:15, from drivers/regulator/max597x-regulator.c:11: drivers/regulator/max597x-regulator.c:481:40: error: 'struct max597x_data' has no member named 'dev' 481 | dev_err(max597x->dev, "IRQ setup failed"); | ^~ include/linux/dev_printk.h:110:25: note: in definition of macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~ drivers/regulator/max597x-regulator.c:481:25: note: in expansion of macro 'dev_err' 481 | dev_err(max597x->dev, "IRQ setup failed"); | ^~~~~~~ At top level: >> drivers/regulator/max597x-regulator.c:360:35: warning: 'max597x_regmap_config' defined but not used [-Wunused-const-variable=] 360 | static const struct regmap_config max597x_regmap_config = { | ^~~~~~~~~~~~~~~~~~~~~
vim +/max597x_regmap_config +360 drivers/regulator/max597x-regulator.c
38493f008deb43 Patrick Rudolph 2022-07-05 359 38493f008deb43 Patrick Rudolph 2022-07-05 @360 static const struct regmap_config max597x_regmap_config = { 38493f008deb43 Patrick Rudolph 2022-07-05 361 .reg_bits = 8, 38493f008deb43 Patrick Rudolph 2022-07-05 362 .val_bits = 8, 38493f008deb43 Patrick Rudolph 2022-07-05 363 .max_register = MAX_REGISTERS, 38493f008deb43 Patrick Rudolph 2022-07-05 364 }; 38493f008deb43 Patrick Rudolph 2022-07-05 365
-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
| |