Messages in this thread Patch in this message | | | Date | Fri, 10 Feb 2023 18:27:19 +0000 | From | Conor Dooley <> | Subject | Re: [PATCH 8/8] kbuild, PCI: microchip: comment out MODULE_LICENSE in non-modules |
| |
Hey Nick,
FYI $subject seems wrong, this is a PCI patch AFAICT.
On Fri, Feb 10, 2023 at 04:47:49PM +0000, Nick Alcock wrote: > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So comment out all uses of MODULE_LICENSE that are not in real modules
This patch should not been needed, there's an existing patch to make this a module: https://lore.kernel.org/linux-riscv/20230111125323.1911373-4-daire.mcnamara@microchip.com/
> (the license declaration is left in as documentation).
I don't really get this one though, why leave it there as "documentation" when the file has an SPDX entry anyway?
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-pci@vger.kernel.org > Cc: linux-riscv@lists.infradead.org
One for the future: How about also CCing those listed in MAINTAINERS for the file you're changing?
Cheers, Conor.
> --- > drivers/pci/controller/pcie-microchip-host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-microchip-host.c b/drivers/pci/controller/pcie-microchip-host.c > index 0ebf7015e9af..08c0b778ce67 100644 > --- a/drivers/pci/controller/pcie-microchip-host.c > +++ b/drivers/pci/controller/pcie-microchip-host.c > @@ -1135,6 +1135,6 @@ static struct platform_driver mc_pcie_driver = { > }; > > builtin_platform_driver(mc_pcie_driver); > -MODULE_LICENSE("GPL"); > +/* MODULE_LICENSE("GPL"); */ > MODULE_DESCRIPTION("Microchip PCIe host controller driver"); > MODULE_AUTHOR("Daire McNamara <daire.mcnamara@microchip.com>"); > -- > 2.39.1.268.g9de2f9a303 > [unhandled content-type:application/pgp-signature] | |