Messages in this thread Patch in this message | | | From | Nick Alcock <> | Subject | [PATCH 3/8] kbuild, ARM: tegra: comment out MODULE_LICENSE in non-modules | Date | Fri, 10 Feb 2023 16:47:44 +0000 |
| |
Since commit 8b41fc4454e ("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations are used to identify modules. As a consequence, uses of the macro in non-modules will cause modprobe to misidentify their containing object file as a module when it is not (false positives), and modprobe might succeed rather than failing with a suitable error message.
So comment out all uses of MODULE_LICENSE that are not in real modules (the license declaration is left in as documentation).
Signed-off-by: Nick Alcock <nick.alcock@oracle.com> Suggested-by: Luis Chamberlain <mcgrof@kernel.org> Cc: Luis Chamberlain <mcgrof@kernel.org> Cc: linux-modules@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: linux-tegra@vger.kernel.org Cc: linux-pci@vger.kernel.org --- drivers/pci/controller/pci-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c index 929f9363e94b..aab1497411c4 100644 --- a/drivers/pci/controller/pci-tegra.c +++ b/drivers/pci/controller/pci-tegra.c @@ -2814,4 +2814,4 @@ static struct platform_driver tegra_pcie_driver = { .remove = tegra_pcie_remove, }; module_platform_driver(tegra_pcie_driver); -MODULE_LICENSE("GPL"); +/* MODULE_LICENSE("GPL"); */ -- 2.39.1.268.g9de2f9a303
| |