Messages in this thread | | | From | Rob Herring <> | Date | Fri, 10 Feb 2023 11:36:16 -0600 | Subject | Re: [PATCH 1/8] kbuild, PCI: generic,versatile: comment out MODULE_LICENSE in non-modules |
| |
On Fri, Feb 10, 2023 at 11:05 AM Nick Alcock <nick.alcock@oracle.com> wrote: > > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message.
How is there an issue when any given module could be built-in instead?
The general trend is to make all PCI host drivers modules, the primary reason this one, IIRC, is not a module is because it is missing remove() hook to de-init the PCI bus. Not too hard to add, but I wanted to do a common devm hook to do that instead of an explicit .remove() hook in each driver. I suppose we could just ignore that and allow building as a module. Unloading is optional anyways.
> So comment out all uses of MODULE_LICENSE that are not in real modules
That's a comment for the series more than just this patch.
> (the license declaration is left in as documentation). > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Rob Herring <robh@kernel.org> > Cc: linux-pci@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/pci/controller/pci-versatile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
| |