lkml.org 
[lkml]   [2023]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH -next v2 0/3] cleanup of devtmpfs_*_node()
Date
In one test, when modprobe zram, no zram device was found in the /dev. 
But don't see any errors printed in jouranls/dmesg. Later we found out
that the reason was that device_add() did not check its return value when
calling devtmpfs_create_node().

The test steps:
1. Set the SElinux label of /dev to user_home_t
2. modprobe zram num_devices=1000

v1 -> v2:
- New patch 1 to add error handling for devtmpfs_create_node().
- use dev_err() to replace pr_err_ratelimited in [2].
- only remove return value of devtmpfs_delete_node() in [3].

Longlong Xia (3):
driver core: add error handling for devtmpfs_create_node()
devtmpfs: add debug info to handle()
devtmpfs: remove return value of devtmpfs_delete_node()

drivers/base/base.h | 4 ++--
drivers/base/core.c | 6 +++++-
drivers/base/devtmpfs.c | 20 ++++++++++++++------
3 files changed, 21 insertions(+), 9 deletions(-)

--
2.25.1

\
 
 \ /
  Last update: 2023-03-27 00:17    [W:2.301 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site