Messages in this thread Patch in this message | | | From | Longlong Xia <> | Subject | [PATCH -next v2 1/3] driver core: add error handling for devtmpfs_create_node() | Date | Fri, 10 Feb 2023 09:54:42 +0000 |
| |
In some cases, devtmpfs_create_node() can return error value. So, make use of it.
Signed-off-by: Longlong Xia <xialonglong1@huawei.com> --- drivers/base/core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c index 7dab705f2937..aaa3088e5456 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -3405,7 +3405,9 @@ int device_add(struct device *dev) if (error) goto SysEntryError; - devtmpfs_create_node(dev); + error = devtmpfs_create_node(dev); + if (error) + goto DevtmpfsError; } /* Notify clients of device addition. This call must come @@ -3461,6 +3463,8 @@ int device_add(struct device *dev) done: put_device(dev); return error; + DevtmpfsError: + device_remove_sys_dev_entry(dev); SysEntryError: if (MAJOR(dev->devt)) device_remove_file(dev, &dev_attr_dev); -- 2.25.1
| |