Messages in this thread | | | Date | Fri, 3 Nov 2023 12:59:45 +0100 | Subject | Re: [PATCH V2 3/7] i2c: sprd: Use global variables to record I2C ack/nack status instead of local variables | From | Krzysztof Kozlowski <> |
| |
On 23/10/2023 10:11, Huangzheng Lai wrote: > We found that when the interrupt bit of the I2C controller is cleared, > the ack/nack bit is also cleared at the same time. After clearing the > interrupt bit in sprd_i2c_isr(), incorrect ack/nack information will be > obtained in sprd_i2c_isr_thread(), resulting in incorrect communication > when nack cannot be recognized. To solve this problem, we used a global > variable to record ack/nack information before clearing the interrupt > bit instead of a local variable. > > Fixes: 8b9ec0719834 ("i2c: Add Spreadtrum I2C controller driver") > Cc: <stable@vger.kernel.org> # v4.14+ > Signed-off-by: Huangzheng Lai <Huangzheng.Lai@unisoc.com>
Fixes must be send independent of features.
Best regards, Krzysztof
| |