Messages in this thread | | | Date | Tue, 3 Oct 2023 14:23:34 -0700 | Subject | Re: [PATCH v6 23/24] x86/resctrl: Move domain helper migration into resctrl_offline_cpu() | From | Reinette Chatre <> |
| |
Hi James,
On 9/14/2023 10:21 AM, James Morse wrote: > When a CPU is taken offline the resctrl filesystem code needs to check > if it was the CPU nominated to perform the periodic overflow and limbo > work. If so, another CPU needs to be chosen to do this work. > > This is currently done in core.c, mixed in with the code that removes > the CPU from the domain's mask, and potentially free()s the domain. > > Move the migration of the overflow and limbo helpers into the filesystem > code, into resctrl_offline_cpu(). As resctrl_offline_cpu() runs before > the architecture code has removed the CPU from the domain mask, the > callers need to be told which CPU is being removed, to avoid picking > it as the new CPU. This uses the exclude_cpu feature previously > added. > > Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com> > Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com> > Tested-By: Peter Newman <peternewman@google.com> > Signed-off-by: James Morse <james.morse@arm.com> > ---
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
| |