Messages in this thread | | | Date | Mon, 2 Oct 2023 10:00:12 -0700 | Subject | Re: [PATCH v6 02/24] x86/resctrl: kfree() rmid_ptrs from rdtgroup_exit() | From | Reinette Chatre <> |
| |
Hi James,
On 9/14/2023 10:21 AM, James Morse wrote:
...
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c > index 725344048f85..a2158c266e41 100644 > --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c > +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c > @@ -3867,6 +3867,11 @@ int __init rdtgroup_init(void) > > void __exit rdtgroup_exit(void) > { > + struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_L3].r_resctrl; > + > + if (r->mon_capable) > + resctrl_exit_mon_l3_config(r); > + > debugfs_remove_recursive(debugfs_resctrl); > unregister_filesystem(&rdt_fs_type); > sysfs_remove_mount_point(fs_kobj, "resctrl");
You did not respond to me when I requested that this be done differently [1]. Without a response letting me know the faults of my proposal or following the recommendation I conclude that my feedback was ignored.
Reinette
[1] https://lore.kernel.org/lkml/1ccd6be5-1dbd-c4a5-659f-ae20761dcce7@intel.com/
| |