Messages in this thread | | | Date | Tue, 3 Oct 2023 14:07:32 -0700 | Subject | Re: [PATCH v6 03/24] x86/resctrl: Create helper for RMID allocation and mondata dir creation | From | Reinette Chatre <> |
| |
Hi James,
On 9/14/2023 10:21 AM, James Morse wrote: > When monitoring is supported, each monitor and control group is allocated > an RMID. For control groups, rdtgroup_mkdir_ctrl_mon() later goes on to > allocate the CLOSID. > > MPAM's equivalent of RMID are not an independent number, so can't be > allocated until the CLOSID is known. An RMID allocation for one CLOSID > may fail, whereas another may succeed depending on how many monitor > groups a control group has. > > The RMID allocation needs to move to be after the CLOSID has been > allocated. > > Move the RMID allocation and mondata dir creation to a helper, this > makes a subsequent change easier to read. > > Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com> > Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > Tested-By: Peter Newman <peternewman@google.com> > Signed-off-by: James Morse <james.morse@arm.com> > ---
Please follow the x86 custom for ordering of tags. You can find this documented in section "Ordering of commit tags" in Documentation/process/maintainer-tip.rst. Please do so for all the x86 patches in this series. I believe this also applies to the tick.h patch.
For this and following patches please consider when a review tag is provided it is done with expectation that the commit tag ordering is fixed. This is the only scenario I am doing it for.
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
| |