lkml.org 
[lkml]   [2023]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 05/10] serial: Convert uart_{,port_}startup() init_hw param to bool
From
On 04. 01. 23, 16:15, Ilpo Järvinen wrote:
> Convert init_hw parameter in uart_startup() and uart_port_startup() to
> bool as code treats them like bool.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> drivers/tty/serial/serial_core.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index c881fefa3d97..a0260a40bdb9 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -181,8 +181,7 @@ static void uart_port_dtr_rts(struct uart_port *uport, int raise)
> * Startup the port. This will be called once per open. All calls
> * will be serialised by the per-port mutex.
> */
> -static int uart_port_startup(struct tty_struct *tty, struct uart_state *state,
> - int init_hw)
> +static int uart_port_startup(struct tty_struct *tty, struct uart_state *state, bool init_hw)
> {
> struct uart_port *uport = uart_port_check(state);
> unsigned long flags;
> @@ -253,8 +252,7 @@ static int uart_port_startup(struct tty_struct *tty, struct uart_state *state,
> return retval;
> }
>
> -static int uart_startup(struct tty_struct *tty, struct uart_state *state,
> - int init_hw)
> +static int uart_startup(struct tty_struct *tty, struct uart_state *state, bool init_hw)

You made both of them over 80 characters/line. Why?

thanks,
--
js
suse labs

\
 
 \ /
  Last update: 2023-03-26 23:28    [W:0.188 / U:1.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site