lkml.org 
[lkml]   [2023]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 02/10] tty: Cleamup tty_port_set_suspended() bool parameter
From
On 04. 01. 23, 16:15, Ilpo Järvinen wrote:
> Make callers pass true/false consistently for bool val.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>


> ---
> drivers/tty/serial/serial_core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index e049c760b738..f9564b1e3dfb 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -312,7 +312,7 @@ static void uart_shutdown(struct tty_struct *tty, struct uart_state *state)
> * a DCD drop (hangup) at just the right time. Clear suspended bit so
> * we don't try to resume a port that has been shutdown.
> */
> - tty_port_set_suspended(port, 0);
> + tty_port_set_suspended(port, false);
>
> /*
> * Do not free() the transmit buffer page under the port lock since
> @@ -1725,7 +1725,7 @@ static void uart_tty_port_shutdown(struct tty_port *port)
> * a DCD drop (hangup) at just the right time. Clear suspended bit so
> * we don't try to resume a port that has been shutdown.
> */
> - tty_port_set_suspended(port, 0);
> + tty_port_set_suspended(port, false);
>
> /*
> * Free the transmit buffer.
> @@ -2346,7 +2346,7 @@ int uart_suspend_port(struct uart_driver *drv, struct uart_port *uport)
> int tries;
> unsigned int mctrl;
>
> - tty_port_set_suspended(port, 1);
> + tty_port_set_suspended(port, true);
> tty_port_set_initialized(port, false);
>
> spin_lock_irq(&uport->lock);
> @@ -2469,7 +2469,7 @@ int uart_resume_port(struct uart_driver *drv, struct uart_port *uport)
> }
> }
>
> - tty_port_set_suspended(port, 0);
> + tty_port_set_suspended(port, false);
> }
>
> mutex_unlock(&port->mutex);

--
js
suse labs

\
 
 \ /
  Last update: 2023-03-26 23:28    [W:1.657 / U:0.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site