| Date | Thu, 5 Jan 2023 07:21:25 +0100 | Subject | Re: [PATCH 08/10] tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool | From | Jiri Slaby <> |
| |
On 04. 01. 23, 16:15, Ilpo Järvinen wrote: > Convert status parameter for ->dcd_change() and > uart_handle_dcd_change() to bool which matches to how the parameter is > used. > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> --- a/include/linux/serial_core.h > +++ b/include/linux/serial_core.h > @@ -896,8 +896,7 @@ static inline bool uart_softcts_mode(struct uart_port *uport) > * The following are helper functions for the low level drivers. > */ > > -extern void uart_handle_dcd_change(struct uart_port *uport, > - unsigned int status); > +extern void uart_handle_dcd_change(struct uart_port *uport, bool status); > extern void uart_handle_cts_change(struct uart_port *uport, > unsigned int status); Note to myself: huh, we still have some superfluous "extern"s in headers.
thanks, -- -- js suse labs
|