Messages in this thread | | | From | Jamal Hadi Salim <> | Date | Wed, 7 Sep 2022 11:03:37 -0400 | Subject | Re: [PATCH net-next,v2 00/22] refactor the walk and lookup hook functions in tc_action_ops |
| |
On Tue, Sep 6, 2022 at 8:11 AM Zhengchao Shao <shaozhengchao@huawei.com> wrote: > > The implementation logic of the walk/lookup hook function in each action > module is the same. Therefore, the two functions can be reconstructed. > When registering tc_action_ops of each action module, the corresponding > net_id is saved to tc_action_ops. In this way, the net_id of the > corresponding module can be directly obtained in act_api without executing > the specific walk and lookup hook functions. Then, generic functions can > be added to replace the walk and lookup hook functions of each action > module. Last, modify each action module in alphabetical order. > > Reserve the walk and lookup interfaces and delete them when they are no > longer used. > > This patchset has been tested by using TDC, and I will add selftest in > other patchset. >
Thank you for running the tdc tests! Please for any future changes to tc try to do the same. And you are going to be a hero if you add more tests! This is a better patchset and overall a nice cleanup. For the series:
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
cheers, jamal
| |