lkml.org 
[lkml]   [2022]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next,v2 01/22] net: sched: act: move global static variable net_id to tc_action_ops
From


On 2022/9/8 1:11, Cong Wang wrote:
> On Tue, Sep 06, 2022 at 08:13:25PM +0800, Zhengchao Shao wrote:
>> diff --git a/include/net/act_api.h b/include/net/act_api.h
>> index 9cf6870b526e..86253f8b69a3 100644
>> --- a/include/net/act_api.h
>> +++ b/include/net/act_api.h
>> @@ -113,6 +113,7 @@ struct tc_action_ops {
>> enum tca_id id; /* identifier should match kind */
>> size_t size;
>> struct module *owner;
>> + unsigned int net_id;
>> int (*act)(struct sk_buff *, const struct tc_action *,
>> struct tcf_result *); /* called under RCU BH lock*/
>> int (*dump)(struct sk_buff *, struct tc_action *, int, int);
>
> This _might_ introduce some unnecessary hole in this struct, could you
> check pahole output?
>
> Thanks.

Hi Wang:
Thank you for your review. I have send v3. And I'll pay
attention next time.

Zhengchao Shao

\
 
 \ /
  Last update: 2022-09-08 08:05    [W:0.074 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site