lkml.org 
[lkml]   [2022]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next,v2 01/22] net: sched: act: move global static variable net_id to tc_action_ops
On Tue, Sep 06, 2022 at 08:13:25PM +0800, Zhengchao Shao wrote:
> diff --git a/include/net/act_api.h b/include/net/act_api.h
> index 9cf6870b526e..86253f8b69a3 100644
> --- a/include/net/act_api.h
> +++ b/include/net/act_api.h
> @@ -113,6 +113,7 @@ struct tc_action_ops {
> enum tca_id id; /* identifier should match kind */
> size_t size;
> struct module *owner;
> + unsigned int net_id;
> int (*act)(struct sk_buff *, const struct tc_action *,
> struct tcf_result *); /* called under RCU BH lock*/
> int (*dump)(struct sk_buff *, struct tc_action *, int, int);

This _might_ introduce some unnecessary hole in this struct, could you
check pahole output?

Thanks.

\
 
 \ /
  Last update: 2022-09-07 19:13    [W:0.117 / U:1.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site