Messages in this thread | | | Date | Wed, 7 Sep 2022 10:11:44 -0700 | From | Cong Wang <> | Subject | Re: [PATCH net-next,v2 01/22] net: sched: act: move global static variable net_id to tc_action_ops |
| |
On Tue, Sep 06, 2022 at 08:13:25PM +0800, Zhengchao Shao wrote: > diff --git a/include/net/act_api.h b/include/net/act_api.h > index 9cf6870b526e..86253f8b69a3 100644 > --- a/include/net/act_api.h > +++ b/include/net/act_api.h > @@ -113,6 +113,7 @@ struct tc_action_ops { > enum tca_id id; /* identifier should match kind */ > size_t size; > struct module *owner; > + unsigned int net_id; > int (*act)(struct sk_buff *, const struct tc_action *, > struct tcf_result *); /* called under RCU BH lock*/ > int (*dump)(struct sk_buff *, struct tc_action *, int, int);
This _might_ introduce some unnecessary hole in this struct, could you check pahole output?
Thanks.
| |