Messages in this thread | | | From | Jiasheng Jiang <> | Subject | Re: Re: [PATCH] net: prestera: acl: Add check for kmemdup | Date | Fri, 30 Sep 2022 13:03:17 +0800 |
| |
On Fri, 30 Sep 2022 00:15:27 +0800 Jakub Kicinski wrote: > On Wed, 28 Sep 2022 17:20:24 +0800 Jiasheng Jiang wrote: >> As the kemdup could return NULL, it should be better to check the return >> value and return error if fails. >> Moreover, the return value of prestera_acl_ruleset_keymask_set() should >> be checked by cascade. >> >> Fixes: 604ba230902d ("net: prestera: flower template support") >> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> > > You must CC the authors of patch you're fixing. > get_maintainer will do that for you I don't understand why people can't > simply run that script :/ You CC linux-kernel for no apparent reason > yet you don't CC the guy who wrote the original patch. > If you could please explain what is going on maybe we can improve the > tooling or something.
Actually, I used get_maintainer scripts and the results is as follow: "./scripts/get_maintainer.pl -f drivers/net/ethernet/marvell/prestera/prestera_acl.c" Taras Chornyi <tchornyi@marvell.com> (supporter:MARVELL PRESTERA ETHERNET SWITCH DRIVER) "David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING DRIVERS) Eric Dumazet <edumazet@google.com> (maintainer:NETWORKING DRIVERS) Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING DRIVERS) Paolo Abeni <pabeni@redhat.com> (maintainer:NETWORKING DRIVERS) netdev@vger.kernel.org (open list:NETWORKING DRIVERS) linux-kernel@vger.kernel.org (open list)
Therefore, I submitted my patch to the above addresses.
And this time I checked the fixes commit, and found that it has two authors: Signed-off-by: Volodymyr Mytnyk <vmytnyk@marvell.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Maybe there is a problem of the script that misses one. Anyway, I have already submitted the same patch and added "vmytnyk@marvell.com" this time.
Thanks, Jiang
| |