Messages in this thread | | | Subject | Re: [PATCH] net: prestera: acl: Add check for kmemdup | From | Joe Perches <> | Date | Fri, 30 Sep 2022 08:20:47 -0700 |
| |
On Fri, 2022-09-30 at 07:29 -0700, Jakub Kicinski wrote: > On Fri, 30 Sep 2022 13:03:17 +0800 Jiasheng Jiang wrote: > > Actually, I used get_maintainer scripts and the results is as follow: > > "./scripts/get_maintainer.pl -f drivers/net/ethernet/marvell/prestera/prestera_acl.c" > > Taras Chornyi <tchornyi@marvell.com> (supporter:MARVELL PRESTERA ETHERNET SWITCH DRIVER) > > "David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING DRIVERS) > > Eric Dumazet <edumazet@google.com> (maintainer:NETWORKING DRIVERS) > > Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING DRIVERS) > > Paolo Abeni <pabeni@redhat.com> (maintainer:NETWORKING DRIVERS) > > netdev@vger.kernel.org (open list:NETWORKING DRIVERS) > > linux-kernel@vger.kernel.org (open list) > > > > Therefore, I submitted my patch to the above addresses. > > > > And this time I checked the fixes commit, and found that it has two > > authors: > > Signed-off-by: Volodymyr Mytnyk <vmytnyk@marvell.com> > > Signed-off-by: David S. Miller <davem@davemloft.net>
IMO: If Volodymyr wants to be a maintainer here, he should put his email as an entry in the MAINTAINERS file for the subsystem.
> > Maybe there is a problem of the script that misses one.
I don't think so. Maybe you have more evidence...
> > Anyway, I have already submitted the same patch and added > > "vmytnyk@marvell.com" this time. > > Ha! So you do indeed use it in a way I wasn't expecting :S > Thanks for the explanation. > > Joe, would you be okay to add a "big fat warning" to get_maintainer > when people try to use the -f flag?
No, not really. -f isn't required when the file is in git anyway.
> Maybe we can also change the message > that's displayed when the script is run without arguments to not > mention -f?
I think that's a poor idea as frequently the script isn't used on patches but simply to identify the maintainers of a particular file or subsystem.
> We're getting quite a few fixes which don't CC author, I'm guessing > Jiasheng's approach may be a common one.
There's no great way to identify "author" or "original submitter" and frequently the "original submitter" isn't a maintainer anyway.
| |