Messages in this thread | | | From | Shenwei Wang <> | Subject | RE: [EXT] Re: [PATCH 1/1] net: fec: using page pool to manage RX buffers | Date | Fri, 30 Sep 2022 20:07:55 +0000 |
| |
> -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: Friday, September 30, 2022 3:05 PM > To: Shenwei Wang <shenwei.wang@nxp.com> > Cc: David S . Miller <davem@davemloft.net>; Eric Dumazet > <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni > <pabeni@redhat.com>; Alexei Starovoitov <ast@kernel.org>; Daniel Borkmann > <daniel@iogearbox.net>; Jesper Dangaard Brouer <hawk@kernel.org>; John > Fastabend <john.fastabend@gmail.com>; Wei Fang <wei.fang@nxp.com>; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; imx@lists.linux.dev > Subject: [EXT] Re: [PATCH 1/1] net: fec: using page pool to manage RX buffers > > Caution: EXT Email > > > -static bool fec_enet_copybreak(struct net_device *ndev, struct sk_buff **skb, > > - struct bufdesc *bdp, u32 length, bool swap) > > +static bool __maybe_unused > > +fec_enet_copybreak(struct net_device *ndev, struct sk_buff **skb, > > + struct bufdesc *bdp, u32 length, bool swap) > > { > > Why add __maybe_unused? If its not used, remove it. We don't leave dead > functions in the code. >
I was thinking to remove them by a separate patch once the page pool solution is accepted.
Regards, Shenwei
> Andrew
| |