lkml.org 
[lkml]   [2022]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] net: fec: using page pool to manage RX buffers
> -static bool fec_enet_copybreak(struct net_device *ndev, struct sk_buff **skb,
> - struct bufdesc *bdp, u32 length, bool swap)
> +static bool __maybe_unused
> +fec_enet_copybreak(struct net_device *ndev, struct sk_buff **skb,
> + struct bufdesc *bdp, u32 length, bool swap)
> {

Why add __maybe_unused? If its not used, remove it. We don't leave
dead functions in the code.

Andrew

\
 
 \ /
  Last update: 2022-09-30 22:06    [W:0.064 / U:3.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site