lkml.org 
[lkml]   [2022]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/15] cxl: Unify debug messages when calling devm_cxl_add_port()
On 07.09.22 22:53:12, Dan Williams wrote:
> Robert Richter wrote:

> > + parent_port = parent_dport ? parent_dport->port : NULL;
> > +
> > port = cxl_port_alloc(uport, component_reg_phys, parent_dport);
> > - if (IS_ERR(port))
> > - return port;
> > + if (IS_ERR(port)) {
> > + rc = PTR_ERR(port);
> > + goto err_out;
>
> While I agree this unifies the error messaging I am not a fan of what
> this does to the readability of the error exits. What about a compromise
> of renaming devm_cxl_add_port to __devm_cxl_add_port() and add back a
> new devm_cxl_add_port that does the unified debug messaging?

Ok, will add a wrapper.

Thanks,

-Robert

\
 
 \ /
  Last update: 2022-09-28 12:33    [W:0.143 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site