Messages in this thread | | | Date | Tue, 6 Sep 2022 09:52:18 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH 03/15] cxl: Unify debug messages when calling devm_cxl_add_port() |
| |
On Tue, 6 Sep 2022 09:30:37 +0200 Robert Richter <rrichter@amd.com> wrote:
> On 31.08.22 10:59:45, Jonathan Cameron wrote: > > On Wed, 31 Aug 2022 10:15:51 +0200 > > Robert Richter <rrichter@amd.com> wrote: > > > > > CXL ports are added in a couple of code paths using > > > devm_cxl_add_port(). Debug messages are individually generated, but > > > are incomplete and inconsistent. Change this by moving its generation > > > to devm_cxl_add_port(). This unifies the messages and reduces code > > > duplication. Also, generate messages on failure. > > > > > > Signed-off-by: Robert Richter <rrichter@amd.com> > > > > This is one for Dan etc as it is mostly a question of how verbose we want > > the debug prints to be plus preference for caller or callee being > > responsible for outputting this sort of message. > > > > Patch looks good to me if we want to make this sort of change. > > Should I take this as a Reviewed-by?
Hmm. I guess I could go that far as its a policy decision rather than correctness
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Thanks, > > -Robert
| |