Messages in this thread | | | From | Chukun Pan <> | Subject | Re: [PATCH-next v1] arm64: dts: rockchip: Enable NVM Express PCIe controller on rock3a | Date | Wed, 28 Sep 2022 18:05:20 +0800 |
| |
Hi,
On 27-09-22, 18:47, Robin Murphy wrote:
> (as a side note, is pcie2x1's vpcie3v3-supply as queued in -next > actually correct? AFAICS the other socket is effectively powered > straight from VCC3V3_SYS so shouldn't have needed VCC3V3_PCIE, > but at least it's there now ready for this one)
Thanks for the correction, I didn't notice this before. You are right, the supply of pcie2x1 comes from VCC3V3_SYS. But if we change supply of pcie2x1 to VCC3V3_SYS, it will cause pcie30phy to fail to initialize normally. The error is the same as the following:
> phy phy-fe8c0000.phy.4: rockchip_p3phy_rk3568_init: lock > failed 0x6890000, check input refclk and power supply > phy phy-fe8c0000.phy.4: phy init failed --> -110 > rockchip-dw-pcie: probe of 3c0800000.pcie failed with error -110
If both vpcie3v3-supply of pcie2x1 and pcie3x2 use VCC3V3_PCIE like the vendor kernel, they can initialized normally.
Thanks, Chukun
-- 2.25.1
| |