lkml.org 
[lkml]   [2022]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 01/11] dt-bindings: remoteproc: mediatek: Give the subnode a persistent name
From
On 27/09/2022 04:55, Tinghan Shen wrote:
> The node name doesn't matter to add the subnode as a cros-ec rpmsg device.
> Give it a clear persistent node name to simplify scp yaml.
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> .../bindings/remoteproc/mtk,scp.yaml | 35 ++++++++++---------
> .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 2 +-
> 2 files changed, 20 insertions(+), 17 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> index 7e091eaffc18..786bed897916 100644
> --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> @@ -58,6 +58,23 @@ properties:
> memory-region:
> maxItems: 1
>
> + cros-ec-rpmsg:
> + type: object

additionalProperties: false on this level

> + description:
> + This subnode represents the rpmsg device. The names of the devices

What are the devices? You wrote that it is one device, not devices.

> + are not important. The properties of this node are defined by the
> + individual bindings for the rpmsg devices.

??? No, you need to define the properties of the node, e.g. by a ref.

> +
> + properties:
> + mediatek,rpmsg-name:
> + $ref: /schemas/types.yaml#/definitions/string-array
> + description:
> + Contains the name for the rpmsg device. Used to match
> + the subnode to rpmsg device announced by SCP.

maxItems... but is it really a string-array?

> +
> + required:
> + - mediatek,rpmsg-name
> +
> required:
> - compatible
> - reg
> @@ -89,21 +106,7 @@ allOf:
> reg-names:
> maxItems: 2
>

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-09-28 19:47    [W:0.145 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site