Messages in this thread |  | | Date | Tue, 27 Sep 2022 20:53:53 +0300 | From | Vladimir Oltean <> | Subject | Re: [PATCH v3 net-next 08/14] net: dsa: felix: update init_regmap to be string-based |
| |
Hi Colin,
On Sun, Sep 25, 2022 at 05:29:22PM -0700, Colin Foster wrote: > During development, it was believed that a wrapper for ocelot_regmap_init() > would be sufficient for the felix driver to work in non-mmio scenarios. > This was merged in during commit 242bd0c10bbd ("net: dsa: ocelot: felix: > add interface for custom regmaps") > > As the external ocelot DSA driver grew closer to an acceptable state, it > was realized that most of the parameters that were passed in from struct > resource *res were useless and ignored. This is due to the fact that the > external ocelot DSA driver utilizes dev_get_regmap(dev, resource->name). > > Instead of simply ignoring those parameters, refactor the API to only > require the name as an argument. MMIO scenarios this will reconstruct the > struct resource before calling ocelot_regmap_init(ocelot, resource). MFD > scenarios need only call dev_get_regmap(dev, name). > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > ---
I don't like how this turned out. I was expecting you not to look at the exported resources from the ocelot-core anymore - that was kind of the point of using just the names rather than the whole resource definitions.
I am also sorry for the mess that the felix driver currently is in, and the fact that some things may have confused you. I will prepare a patch set which offers an alternative to this, and send it for review.
|  |