Messages in this thread Patch in this message | | | From | Colin Foster <> | Subject | [PATCH v3 net-next 07/14] net: dsa: felix: populate mac_capabilities for all ports | Date | Sun, 25 Sep 2022 17:29:21 -0700 |
| |
phylink_generic_validate() requires that mac_capabilities is correctly populated. While no existing felix drivers have used phylink_generic_validate(), the ocelot_ext.c driver will. Populate this element so the use of existing functions is possible.
Signed-off-by: Colin Foster <colin.foster@in-advantage.com> ---
v3 * No change
v2 * Updated commit message to indicate "no existing felix drivers" instead of "no existing drivers"
v1 from previous RFC: * New patch
--- drivers/net/dsa/ocelot/felix.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c index 07c2f1b6913d..a8196cdedcc5 100644 --- a/drivers/net/dsa/ocelot/felix.c +++ b/drivers/net/dsa/ocelot/felix.c @@ -1050,6 +1050,9 @@ static void felix_phylink_get_caps(struct dsa_switch *ds, int port, __set_bit(ocelot->ports[port]->phy_mode, config->supported_interfaces); + + config->mac_capabilities = MAC_SYM_PAUSE | MAC_ASYM_PAUSE | MAC_10 | + MAC_100 | MAC_1000FD | MAC_2500FD; } static void felix_phylink_validate(struct dsa_switch *ds, int port, -- 2.25.1
| |