lkml.org 
[lkml]   [2022]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 2/4] dt-bindings: remoteproc: qcom: Convert wcnss documentation to YAML
From
On 21/09/2022 06:36, Sireesh Kodali wrote:
> This is a direct conversion of the existing txt documentation to YAML.
> It is in preparation for the addition of pronto-v3 to the docs. This
> patch doesn't document any of the existing subnodes/properties that are
> not documented in the existing txt file. That is done in a separate
> patch.
>
> Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com>

Thank you for your patch. There is something to discuss/improve.
(...)

> +
> + memory-region:
> + maxItems: 1
> + description: reserved-memory for the WCNSS core
> +
> + smd-edge:
> + $ref: /schemas/remoteproc/qcom,smd-edge.yaml#
> + description:
> + Qualcomm Shared Memory subnode which represents communication edge,
> + channels and devices related to the ADSP.
> +
> + iris:
> + type: object
> + description:
> + The iris subnode of the WCNSS PIL is used to describe the attached RF module
> + and its resource dependencies.

On this level of indentation (for iris):
additionalProperties: false

> +
> + properties:
> + compatible:
> + enum:
> + - qcom,wcn3620
> + - qcom,wcn3660
> + - qcom,wcn3660b
> + - qcom,wcn3680
> +
> + clocks:
> + minItems: 1
> + items:
> + - description: XO clock
> + - description: RF clock
> +
> + clock-names:
> + minItems: 1
> + items:
> + - const: xo
> + - const: rf
> +
> + vddxo-supply:
> + description:
> + Reference to the regulator to be held on behalf of the booting WCNSS
> + core
> +
> + vddrfa-supply:
> + description:
> + Reference to the regulator to be held on behalf of the booting WCNSS
> + core
> +
> + vddpa-supply:
> + description:
> + Reference to the regulator to be held on behalf of the booting WCNSS
> + core
> +
> + vdddig-supply:
> + description:
> + Reference to the regulator to be held on behalf of the booting WCNSS
> + core
> +
> + required:
> + - compatible
> + - clocks
> + - clock-names
> + - vddxo-supply
> + - vddrfa-supply
> + - vddpa-supply
> + - vdddig-supply
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - interrupts-extended

You require only interrupts and interrupts-extended satisfy it, unless
this is a result of bug in dtschema?

> + - interrupt-names
> + - iris
> + - vddpx-supply
> + - memory-region
> + - smd-edge
> +
> +additionalProperties: false

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-09-21 21:19    [W:0.077 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site