lkml.org 
[lkml]   [2022]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next 1/3] dt-bindings: net: dsa: mt7530: replace label = "cpu" with proper checks
From
On 12.09.2022 20:50, Vladimir Oltean wrote:
> The fact that some DSA device trees use 'label = "cpu"' for the CPU port
> is nothing but blind cargo cult copying. The 'label' property was never
> part of the DSA DT bindings for anything except the user ports, where it
> provided a hint as to what name the created netdevs should use.
>
> DSA does use the "cpu" port label to identify a CPU port in dsa_port_parse(),
> but this is only for non-OF code paths (platform data).
>
> The proper way to identify a CPU port is to look at whether the
> 'ethernet' phandle is present.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Arınç ÜNAL <arinc.unal@arinc9.com>

Arınç

> ---
> .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> index f9e7b6e20b35..fa271ee16b5e 100644
> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> @@ -163,9 +163,7 @@ patternProperties:
> allOf:
> - $ref: dsa-port.yaml#
> - if:
> - properties:
> - label:
> - const: cpu
> + required: [ ethernet ]
> then:
> required:
> - phy-mode
> @@ -187,9 +185,7 @@ $defs:
> patternProperties:
> "^(ethernet-)?port@[0-9]+$":
> if:
> - properties:
> - label:
> - const: cpu
> + required: [ ethernet ]
> then:
> if:
> properties:
> @@ -215,9 +211,7 @@ $defs:
> patternProperties:
> "^(ethernet-)?port@[0-9]+$":
> if:
> - properties:
> - label:
> - const: cpu
> + required: [ ethernet ]
> then:
> if:
> properties:

\
 
 \ /
  Last update: 2022-09-13 10:21    [W:0.144 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site