Messages in this thread | | | Date | Tue, 13 Sep 2022 18:55:05 +0300 | Subject | Re: [PATCH net-next 1/3] dt-bindings: net: dsa: mt7530: replace label = "cpu" with proper checks | From | Arınç ÜNAL <> |
| |
On 12.09.2022 20:50, Vladimir Oltean wrote: > The fact that some DSA device trees use 'label = "cpu"' for the CPU port > is nothing but blind cargo cult copying. The 'label' property was never > part of the DSA DT bindings for anything except the user ports, where it > provided a hint as to what name the created netdevs should use. > > DSA does use the "cpu" port label to identify a CPU port in dsa_port_parse(), > but this is only for non-OF code paths (platform data). > > The proper way to identify a CPU port is to look at whether the > 'ethernet' phandle is present. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
I realised "dt-bindings: net: dsa: mt7530:" prefix is used here instead of the usual "dt-bindings: net: dsa: mediatek,mt7530:". Does this matter?
Arınç
| |