| Date | Tue, 13 Sep 2022 17:57:09 +0200 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH 5.10 59/79] net: fec: Use a spinlock to guard `fep->ptp_clk_on` |
| |
On 13.09.2022 16:05:04, Greg Kroah-Hartman wrote: > From: Csókás Bence <csokas.bence@prolan.hu> > > [ Upstream commit b353b241f1eb9b6265358ffbe2632fdcb563354f ] > > Mutexes cannot be taken in a non-preemptible context, > causing a panic in `fec_ptp_save_state()`. Replacing > `ptp_clk_mutex` by `tmreg_lock` fixes this. > > Fixes: 6a4d7234ae9a ("net: fec: ptp: avoid register access when ipg clock is disabled") > Fixes: f79959220fa5 ("fec: Restart PPS after link state change") > Reported-by: Marc Kleine-Budde <mkl@pengutronix.de> > Link: https://lore.kernel.org/all/20220827160922.642zlcd5foopozru@pengutronix.de/ > Signed-off-by: Csókás Bence <csokas.bence@prolan.hu> > Tested-by: Francesco Dolcini <francesco.dolcini@toradex.com> # Toradex Apalis iMX6 > Link: https://lore.kernel.org/r/20220901140402.64804-1-csokas.bence@prolan.hu > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > Signed-off-by: Sasha Levin <sashal@kernel.org>
If possible please drop this patch, a revert for this is pending. For details see:
https://lore.kernel.org/all/20220913141917.ukoid65sqao5f4lg@pengutronix.de/
regards, Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [unhandled content-type:application/pgp-signature] |