lkml.org 
[lkml]   [2022]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 56/79] tipc: fix shift wrapping bug in map_get()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit e2b224abd9bf45dcb55750479fc35970725a430b ]

    There is a shift wrapping bug in this code so anything thing above
    31 will return false.

    Fixes: 35c55c9877f8 ("tipc: add neighbor monitoring framework")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/tipc/monitor.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/tipc/monitor.c b/net/tipc/monitor.c
    index a37190da5a504..1d90f39129ca0 100644
    --- a/net/tipc/monitor.c
    +++ b/net/tipc/monitor.c
    @@ -130,7 +130,7 @@ static void map_set(u64 *up_map, int i, unsigned int v)

    static int map_get(u64 up_map, int i)
    {
    - return (up_map & (1 << i)) >> i;
    + return (up_map & (1ULL << i)) >> i;
    }

    static struct tipc_peer *peer_prev(struct tipc_peer *peer)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-09-13 16:52    [W:4.139 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site