lkml.org 
[lkml]   [2022]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 64/79] RDMA/mlx5: Set local port to one when accessing counters
    Date
    From: Chris Mi <cmi@nvidia.com>

    [ Upstream commit 74b30b3ad5cec95d2647e796d10137438a098bc1 ]

    When accessing Ports Performance Counters Register (PPCNT),
    local port must be one if it is Function-Per-Port HCA that
    HCA_CAP.num_ports is 1.

    The offending patch can change the local port to other values
    when accessing PPCNT after enabling switchdev mode. The following
    syndrome will be printed:

    # cat /sys/class/infiniband/rdmap4s0f0/ports/2/counters/*
    # dmesg
    mlx5_core 0000:04:00.0: mlx5_cmd_check:756:(pid 12450): ACCESS_REG(0x805) op_mod(0x1) failed, status bad parameter(0x3), syndrome (0x1e5585)

    Fix it by setting local port to one for Function-Per-Port HCA.

    Fixes: 210b1f78076f ("IB/mlx5: When not in dual port RoCE mode, use provided port as native")
    Reviewed-by: Mark Bloch <mbloch@nvidia.com>
    Signed-off-by: Chris Mi <cmi@nvidia.com>
    Link: https://lore.kernel.org/r/6c5086c295c76211169e58dbd610fb0402360bab.1661763459.git.leonro@nvidia.com
    Signed-off-by: Leon Romanovsky <leon@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/mlx5/mad.c | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/drivers/infiniband/hw/mlx5/mad.c b/drivers/infiniband/hw/mlx5/mad.c
    index 9bb9bb058932f..cca7a4a6bd82d 100644
    --- a/drivers/infiniband/hw/mlx5/mad.c
    +++ b/drivers/infiniband/hw/mlx5/mad.c
    @@ -166,6 +166,12 @@ static int process_pma_cmd(struct mlx5_ib_dev *dev, u8 port_num,
    mdev = dev->mdev;
    mdev_port_num = 1;
    }
    + if (MLX5_CAP_GEN(dev->mdev, num_ports) == 1) {
    + /* set local port to one for Function-Per-Port HCA. */
    + mdev = dev->mdev;
    + mdev_port_num = 1;
    + }
    +
    /* Declaring support of extended counters */
    if (in_mad->mad_hdr.attr_id == IB_PMA_CLASS_PORT_INFO) {
    struct ib_class_port_info cpi = {};
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-09-13 16:58    [W:4.238 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site