Messages in this thread | | | From | Punit Agrawal <> | Subject | Re: [PATCH v6] cpufreq: amd-pstate: cleanup the unused and duplicated headers declaration | Date | Thu, 01 Sep 2022 15:55:27 +0100 |
| |
Hi Perry,
Perry Yuan <Perry.Yuan@amd.com> writes:
> Cleanup the headers declaration which are not used > actually and some duplicated declaration which is declarated in some > other headers already, it will help to simplify the header part. > > Reviewed-by: Huang Rui <ray.huang@amd.com> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > Signed-off-by: Perry Yuan <Perry.Yuan@amd.com> > --- > drivers/cpufreq/amd-pstate.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c > index 9ac75c1cde9c..9cf7bc162e7c 100644 > --- a/drivers/cpufreq/amd-pstate.c > +++ b/drivers/cpufreq/amd-pstate.c > @@ -31,19 +31,15 @@ > #include <linux/compiler.h> > #include <linux/dmi.h> > #include <linux/slab.h> > -#include <linux/acpi.h> > #include <linux/io.h> > #include <linux/delay.h> > #include <linux/uaccess.h> > #include <linux/static_call.h> > > -#include <acpi/processor.h> > #include <acpi/cppc_acpi.h> > > #include <asm/msr.h> > #include <asm/processor.h> > -#include <asm/cpufeature.h> > -#include <asm/cpu_device_id.h> > #include "amd-pstate-trace.h" > > #define AMD_PSTATE_TRANSITION_LATENCY 0x20000
The patch has the same issue as mentioned in the previous version.
Please don't remove any header includes whose definitions are directly used in amd-pstate.c. Look at example from my previous comment.
| |