lkml.org 
[lkml]   [2022]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v6] cpufreq: amd-pstate: cleanup the unused and duplicated headers declaration
Date
[AMD Official Use Only - General]

Hi Viresh,

> -----Original Message-----
> From: Viresh Kumar <viresh.kumar@linaro.org>
> Sent: Thursday, September 1, 2022 2:32 PM
> To: Yuan, Perry <Perry.Yuan@amd.com>
> Cc: rafael.j.wysocki@intel.com; Huang, Ray <Ray.Huang@amd.com>; Sharma,
> Deepak <Deepak.Sharma@amd.com>; Limonciello, Mario
> <Mario.Limonciello@amd.com>; Fontenot, Nathan
> <Nathan.Fontenot@amd.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Su, Jinzhou (Joe) <Jinzhou.Su@amd.com>;
> Huang, Shimmer <Shimmer.Huang@amd.com>; Du, Xiaojian
> <Xiaojian.Du@amd.com>; Meng, Li (Jassmine) <Li.Meng@amd.com>; linux-
> pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v6] cpufreq: amd-pstate: cleanup the unused and
> duplicated headers declaration
>
> [CAUTION: External Email]
>
> On 01-09-22, 14:23, Perry Yuan wrote:
> > Cleanup the headers declaration which are not used actually and
>
> This is okay.

Thank you help to confirm this .

>
> > some duplicated declaration which is declarated in some other headers
> > already, it will help to simplify the header part.
>
> This isn't.
>
> Every file should directly include headers they use definitions from, instead of
> relying on indirect inclusions.
>
> --
> Viresh

Do I need to update the commit with another V7 version ?
If need, I will update this later.

Thank you.

Perry.

\
 
 \ /
  Last update: 2022-09-01 08:58    [W:0.058 / U:1.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site