lkml.org 
[lkml]   [2022]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6] cpufreq: amd-pstate: cleanup the unused and duplicated headers declaration
On 01-09-22, 06:56, Yuan, Perry wrote:
> > On 01-09-22, 14:23, Perry Yuan wrote:
> > > Cleanup the headers declaration which are not used actually and
> >
> > This is okay.
>
> Thank you help to confirm this .
>
> >
> > > some duplicated declaration which is declarated in some other headers
> > > already, it will help to simplify the header part.
> >
> > This isn't.
> >
> > Every file should directly include headers they use definitions from, instead of
> > relying on indirect inclusions.
> >
> > --
> > Viresh
>
> Do I need to update the commit with another V7 version ?

I am not sure which headers you removed are still required, working
for now since included indirectly. If there are any, then better to
get a new version out.

--
viresh

\
 
 \ /
  Last update: 2022-09-01 09:03    [W:0.160 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site