Messages in this thread | | | From | "Sa, Nuno" <> | Subject | RE: [PATCH v3 14/14] iio: hmc425a: simplify using devm_regulator_get_enable() | Date | Tue, 30 Aug 2022 11:49:07 +0000 |
| |
> From: Matti Vaittinen <mazziesaccount@gmail.com> > Sent: Friday, August 19, 2022 9:21 PM > To: Matti Vaittinen <mazziesaccount@gmail.com>; Matti Vaittinen > <matti.vaittinen@fi.rohmeurope.com> > Cc: Lars-Peter Clausen <lars@metafoo.de>; Hennerich, Michael > <Michael.Hennerich@analog.com>; Jonathan Cameron > <jic23@kernel.org>; linux-iio@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH v3 14/14] iio: hmc425a: simplify using > devm_regulator_get_enable() > > [External] > > Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(), > add_action_or_reset(regulator_disable)' and use the > devm_regulator_get_enable() and drop the pointer to the regulator. > This simplifies code and makes it less tempting to add manual control > for the regulator which is also controlled by devm. > > Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> > > ---
Acked-by: Nuno Sá <nuno.sa@analog.com>
(I see that in this patch you are not using dev_err_probe(). Maybe some consistency in the series and where applicable would be appropriate :))
| |